Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug : #60/heredoc 오류 수정 #62

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Bug : #60/heredoc 오류 수정 #62

merged 4 commits into from
Jan 15, 2023

Conversation

wonyangs
Copy link
Collaborator

🚅 PR 한 줄 요약

리다이렉션과 heredoc 오류 수정

🧑‍💻 PR 세부 내용

문제사항 및 원인

  • 부모 프로세스에서 실행되는 빌트인 함수의 리다이렉션 적용이 제대로 되지 않음
    • 부모 프로세스의 표준 입출력을 리다이렉션을 통해 변경 후 원상 복구 시켜놓지 않았음
  • heredoc이 제대로 실행되지 않던 오류 [Bug] heredoc이 안돼요 #60
    • apply_redirection 함수가 두번 적용되고 있었음

변경사항

  • 부모 프로세스의 리다이렉션 변경 전 기존 표준 입출력 fd를 저장해두고 다시 복구
  • apply_redirection 함수 수정
  • ft_env의 argument 오류 반환값을 1에서 127으로 수정

@wonyangs wonyangs linked an issue Jan 15, 2023 that may be closed by this pull request
[Bug] heredoc이 안돼요 #60
Closed
@wonyangs wonyangs self-assigned this Jan 15, 2023
@wonyangs wonyangs added the 🐞 Bug 문제 발생 label Jan 15, 2023
mingxoxo
mingxoxo approved these changes Jan 15, 2023
View reviewed changes
Copy link
Owner

@mingxoxo mingxoxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~~

@mingxoxo mingxoxo merged commit 1dcce6b into main Jan 15, 2023
@mingxoxo mingxoxo deleted the bug/#60/heredoc-error branch January 15, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingxoxo mingxoxo mingxoxo approved these changes

Assignees

@wonyangs wonyangs

Labels
🐞 Bug 문제 발생
Projects
No open projects
Minishell backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] heredoc이 안돼요
2 participants
@wonyangs @mingxoxo