Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: #54/터미널 세팅 복구 #56

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Bug: #54/터미널 세팅 복구 #56

merged 1 commit into from
Jan 15, 2023

Conversation

wonyangs
Copy link
Collaborator

🚅 PR 한 줄 요약

명령어 실행 후 터미널 설정이 돌아오지 않는 오류를 수정

🧑‍💻 PR 세부 내용

원인 및 해결

  • 명령어 실행 전 자식 프로세스에서 미니쉘 시작시 바꾼 터미널 세팅을 되돌림
  • 자식 프로세스에서 바꾼 터미널 세팅도 부모 프로세스에서 영향이 있었음
  • 명령어 실행 과정이 끝난 후 다시 터미널 세팅을 해줌

📸 스크린샷

스크린샷 2023-01-14 오후 10 51 50

@wonyangs wonyangs added the 🐞 Bug 문제 발생 label Jan 14, 2023
@wonyangs wonyangs requested a review from mingxoxo January 14, 2023 13:52
@wonyangs wonyangs self-assigned this Jan 14, 2023
@wonyangs wonyangs linked an issue Jan 14, 2023 that may be closed by this pull request
[Bug] 명령어를 한 번 실행하고 난 후 터미널 설정이 초기화돼요 #54
Closed
mingxoxo
mingxoxo approved these changes Jan 14, 2023
View reviewed changes
Copy link
Owner

@mingxoxo mingxoxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
터미널 설정을 어렵네요 😮

@mingxoxo mingxoxo changed the title bug: #54/터미널 세팅 복구 Bug: #54/터미널 세팅 복구 Jan 14, 2023
@wonyangs wonyangs merged commit 7e9faea into main Jan 15, 2023
@wonyangs wonyangs deleted the bug/#54/reset-terminal-setting branch January 15, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingxoxo mingxoxo mingxoxo approved these changes

Assignees

@wonyangs wonyangs

Labels
🐞 Bug 문제 발생
Projects
No open projects
Minishell backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] 명령어를 한 번 실행하고 난 후 터미널 설정이 초기화돼요
2 participants
@wonyangs @mingxoxo