Bug : #53/선언되지 않은 환경변수 에러 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingxoxo
approved these changes
Jan 14, 2023
| @@ -34,6 +34,7 @@ static t_error child_execve(t_tnode *node, char *path, char **argv) | |||
| if (is_builtin_cmd(node) == true) | |||
| exit(builtin_execve(builtin, argv, &(g_var.envp), 1)); | |||
| execve(path, argv, g_var.envp.arr); | |||
| exit(0); | |||
There was a problem hiding this comment.
로직대로라면 실행될 일이 없겠지만, 이번 이슈 같은 상황을 방지하기 위해 추가했습니다.
무한루프 걸리는 상황보다는 그냥 종료되는게 안전하니까요 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚅 PR 한 줄 요약
선언되지 않은 환경변수가 들어왔을 때 발생하는 오류 수정
🧑💻 PR 세부 내용
원인
/bin/와 같이 디렉토리를 가르키게 됨수정사항
command not found에러 출력📸 스크린샷