Validate user inputs #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
a-tour-ist
commented
Nov 30, 2024
a-tour-ist
commented
- fixes MoreMesecons/moremesecons_entity_detector/init.lua:68: bad argument #2 to 'set_string' (string expected, got table) #38 and a similar crash with the adjustable player detector
- enforces a distance limit for the adjustable player detector
SmallJoker
reviewed
Dec 9, 2024
| @@ -76,7 +77,7 @@ local object_detector_digiline = { | |||
| make_formspec(meta) | |||
| end | |||
| end | |||
| if msg.scanname then | |||
| if msg.scanname and type(msg.scanname) == "string" then | |||
There was a problem hiding this comment.
This is equivalent:
Suggested change
| if msg.scanname and type(msg.scanname) == "string" then | |
| if type(msg.scanname) == "string" then |
| @@ -36,7 +36,8 @@ local object_detector_scan = function (pos) | |||
| local scanname = meta:get_string("scanname") | |||
| local scan_all = scanname == "" | |||
| local scan_names = scanname:split(',') | |||
| local radius = meta:get_int("radius") | |||
| local max_radius = moremesecons.setting("adjustable_player_detector", "max_radius", 16, 0) | |||
There was a problem hiding this comment.
Please move this outside the function. That way moremesecons.setting will check the validity of the setting on startup, and only log a warning once (if it happens to be invalid).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.