Merge pull request #123 from mineiros-io/soerenmartius/fix-app-instal…

…lations Fix type of var.app_installations
mineiros-io · May 11, 2022 · 9f3f601 · 9f3f601
2 parents 5eaaad1 + 001309a
commit 9f3f601
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.16.2]
+
+### Fixed
+
+- `var.app_installations` should be a of type `set(string)` instead of `set(number)`
+
 ## [0.16.1]
 
 ### Added
@@ -374,7 +380,8 @@ Please review plans and report regressions and issues asap so we can improve doc
 - This is the initial release of our GitHub Repository module with support for
   creating and managing GitHub Repositories for Organizations.
 
-[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.1...HEAD
+[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.2...HEAD
+[0.16.2]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.1...v0.16.2
 [0.16.1]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.0...v0.16.1
 [0.16.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.15.0...v0.16.0
 [0.15.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.14.0...v0.15.0

diff --git a/README.md b/README.md
@@ -811,7 +811,7 @@ This is due to some terraform limitation and we will update the module once terr
 
 #### App Installations
 
-- [**`app_installations`**](#var-app_installations): *(Optional `set(number)`)*<a name="var-app_installations"></a>
+- [**`app_installations`**](#var-app_installations): *(Optional `set(string)`)*<a name="var-app_installations"></a>
 
   A set of GitHub App IDs to be installed in this repository.
 
@@ -820,7 +820,7 @@ This is due to some terraform limitation and we will update the module once terr
   Example:
 
   ```hcl
-  app_installations = [25405144, 12556423]
+  app_installations = ["05405144", "12556423"]
   ```
 
 ### Module Configuration

diff --git a/README.tfdoc.hcl b/README.tfdoc.hcl
@@ -1057,14 +1057,14 @@ section {
         title = "App Installations"
 
         variable "app_installations" {
-          type        = set(number)
+          type        = set(string)
           default     = {}
           description = <<-END
             A set of GitHub App IDs to be installed in this repository.
           END
 
           readme_example = <<-END
-            app_installations = [25405144, 12556423]
+            app_installations = ["05405144", "12556423"]
           END
         }
       }

diff --git a/test/unit-complete/variables.tf b/test/unit-complete/variables.tf
@@ -257,7 +257,7 @@ variable "autolink_references" {
 }
 
 variable "app_installations" {
-  type        = set(number)
+  type        = set(string)
   description = "A list of GitHub App IDs to be installed in this repository."
   default     = []
 }
diff --git a/variables.tf b/variables.tf
@@ -529,7 +529,7 @@ variable "archive_on_destroy" {
 }
 
 variable "app_installations" {
-  type        = set(number)
+  type        = set(string)
   description = "(Optional) A list of GitHub App IDs to be installed in this repository."
   default     = []
 }