-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new cloud
block backend for Terraform Cloud
#76
Conversation
…rm_cloud_remote_backend Integrate with Terraform Cloud Remote Backend
@GoodmanBen Thank you for working on this and fixing many typos 😇 Your patch looks almost good. I left some review comments. While some tests for executor depends on OS, it's no problem as long as the CI passes, but if you want to run it locally, run the test inside a docker-compose environment. The exact commands that CI is executing are as follows: tfmigrate/.github/workflows/test.yaml Lines 56 to 66 in 2959827
As you pointed out in #77, it seems that we need a contribution guide. Sorry for your inconvenience. |
…ted_changes Suggested changes
@minamijoyo updated with the suggested changes and the linter fix. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you for your contribution!
@GoodmanBen Released it in v0.3.2 🚀 |
Resolves #75. Some other files were edited to fix small typos in documentation comments.
Adds a configuration attribute wherein the user specifies if the remote backend
is_backend_terraform_cloud
. This attribute defaults tofalse
, so existing users not using thecloud
block for their remote backend will not need to turnTesting:
cloud
bock specifying the backend with my use case. Thetfmigrate
block to handle this use case looks as follows:All tests pass when run folder by folder, except for some tests in
TestExecutorEnv
andTestExecutorDir
which are failing when thetfexec
folder's tests are run.This might be an issue with how I'm trying to run the tests, since none of my changes should be effecting the presence of executables? If this is indeed a bug from my code changes, or if there is a better way to run the tests, please let me know! It is hard to see how the changes which pass in an integration test would lead to the observed testing error.