Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enable resource group api in milvus client #2513

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: milvus-io/milvus#38739
this PR enable those API in milvus client:

  • create_resource_group
  • update_resource_groups
  • drop_resource_group
  • describe_resource_group
  • list_resource_groups
  • transfer_replica

cause the resource group prefer to use declarative api, so the transfer_node API is deprecated in milvus client, it's recommand to use update_resource_group to manage node num in resource group.

this PR enable those API in milvus client:
- create_resource_group
- update_resource_groups
- drop_resource_group
- describe_resource_group
- list_resource_groups
- transfer_replica

cause the resource group prefer to use declarative api, so the
transfer_node API is deprecated in milvus client, it's recommand to use
update_resource_group to manage node num in resource group.

Signed-off-by: Wei Liu <[email protected]>
@XuanYang-cn XuanYang-cn self-requested a review December 25, 2024 09:06
@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Dec 25, 2024
@mergify mergify bot added the ci-passed label Dec 25, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: weiliu1031, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a6fbc66 into milvus-io:master Dec 25, 2024
11 checks passed
weiliu1031 added a commit to weiliu1031/pymilvus that referenced this pull request Dec 26, 2024
issue: milvus-io/milvus#38739
this PR enable those API in milvus client:
- create_resource_group
- update_resource_groups
- drop_resource_group
- describe_resource_group
- list_resource_groups
- transfer_replica

cause the resource group prefer to use declarative api, so the
transfer_node API is deprecated in milvus client, it's recommand to use
update_resource_group to manage node num in resource group.

Signed-off-by: Wei Liu <[email protected]>
weiliu1031 added a commit to weiliu1031/pymilvus that referenced this pull request Dec 26, 2024
issue: milvus-io/milvus#38739
this PR enable those API in milvus client:
- create_resource_group
- update_resource_groups
- drop_resource_group
- describe_resource_group
- list_resource_groups
- transfer_replica

cause the resource group prefer to use declarative api, so the
transfer_node API is deprecated in milvus client, it's recommand to use
update_resource_group to manage node num in resource group.

Signed-off-by: Wei Liu <[email protected]>
@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch labels Dec 26, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 26, 2024
issue: milvus-io/milvus#38739
pr: #2513
this PR enable those API in milvus client:
- create_resource_group
- update_resource_groups
- drop_resource_group
- describe_resource_group
- list_resource_groups
- transfer_replica

cause the resource group prefer to use declarative api, so the
transfer_node API is deprecated in milvus client, it's recommand to use
update_resource_group to manage node num in resource group.

Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Dec 26, 2024
issue: milvus-io/milvus#38739
pr: #2513
this PR enable those API in milvus client:
- create_resource_group
- update_resource_groups
- drop_resource_group
- describe_resource_group
- list_resource_groups
- transfer_replica

cause the resource group prefer to use declarative api, so the
transfer_node API is deprecated in milvus client, it's recommand to use
update_resource_group to manage node num in resource group.

Signed-off-by: Wei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants