fix: fix list aliases rpc call #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before fix: after fix: |
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
listalias
branch
from
07d210a to
ec57039
Compare
|
/lgtm |
XuanYang-cn
added
the
PR | need to cherry-pick to 2.x
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaoting-huang, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shaoting-huang
added a commit
to shaoting-huang/pymilvus
that referenced
this pull request
Dec 4, 2024
ListAliases SDK rpc call is `describeCollection`, which causes listing aliases successfully without granted. issue: milvus-io/milvus#38052 Signed-off-by: shaoting-huang <[email protected]>
XuanYang-cn
added
PR | cherry-picked to 2.x
shaoting-huang
added a commit
to shaoting-huang/pymilvus
that referenced
this pull request
Dec 4, 2024
ListAliases SDK rpc call is `describeCollection`, which causes listing aliases successfully without granted. issue: milvus-io/milvus#38052 Signed-off-by: shaoting-huang <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 4, 2024
cherry-pick from master: #2399, #2403 issue: milvus-io/milvus#37031, milvus-io/milvus#38052 --------- Signed-off-by: shaoting-huang <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 4, 2024
cherry-pick from master: #2399, #2403 issue: milvus-io/milvus#37031, milvus-io/milvus#38052 --------- Signed-off-by: shaoting-huang <[email protected]>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListAliases SDK rpc call is
describeCollection, which causes listing aliases successfully without granted.issue: milvus-io/milvus#38052