fix: grant ManualCompact api doesn't work #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuanYang-cn
added
the
PR | need to cherry-pick to 2.x
cause RBAC require to check collection name, but ManualCompact rpc pass collection id in request, so grant ManualCompact api doesn't work. This PR refine compact api impl to pass collection name in request. Signed-off-by: Wei Liu <[email protected]>
weiliu1031
force-pushed
the
fix_manual_compact
branch
from
cfa78ec to
e50ce6f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weiliu1031, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weiliu1031
added a commit
to weiliu1031/pymilvus
that referenced
this pull request
Dec 24, 2024
issue: milvus-io/milvus#38086 cause RBAC require to check collection name, but ManualCompact rpc pass collection id in request, so grant ManualCompact api doesn't work. This PR refine compact api impl to pass collection name in request. Signed-off-by: Wei Liu <[email protected]>
weiliu1031
added a commit
to weiliu1031/pymilvus
that referenced
this pull request
Dec 24, 2024
issue: milvus-io/milvus#38086 cause RBAC require to check collection name, but ManualCompact rpc pass collection id in request, so grant ManualCompact api doesn't work. This PR refine compact api impl to pass collection name in request. Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 24, 2024
issue: milvus-io/milvus#38086 pr: #2396 cause RBAC require to check collection name, but ManualCompact rpc pass collection id in request, so grant ManualCompact api doesn't work. This PR refine compact api impl to pass collection name in request. Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 24, 2024
issue: milvus-io/milvus#38086 pr: #2396 cause RBAC require to check collection name, but ManualCompact rpc pass collection id in request, so grant ManualCompact api doesn't work. This PR refine compact api impl to pass collection name in request. Signed-off-by: Wei Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: milvus-io/milvus#38086
cause RBAC require to check collection name, but ManualCompact rpc pass collection id in request, so grant ManualCompact api doesn't work.
This PR refine compact api impl to pass collection name in request.