Skip to content

enhance: Remove unnecessary segment validation on worker node

Codecov / codecov/project succeeded Dec 13, 2024 in 1s

81.07% (target 77.00%)

View this Pull Request on Codecov

81.07% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 80.64516% with 18 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (10460ed) to head (59e1d76).
Report is 1 commits behind head on master.

Current head 59e1d76 differs from pull request most recent head 25260fe

Please upload reports for the commit 25260fe to get more accurate results.

Files with missing lines Patch % Lines
internal/querynodev2/segments/search.go 75.67% 8 Missing and 1 partial ⚠️
internal/querynodev2/segments/statistics.go 45.45% 6 Missing ⚠️
internal/querynodev2/segments/retrieve.go 81.81% 2 Missing ⚠️
internal/querynodev2/handlers.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38108      +/-   ##
==========================================
+ Coverage   80.89%   81.07%   +0.18%     
==========================================
  Files        1373     1371       -2     
  Lines      192959   191201    -1758     
==========================================
- Hits       156092   155019    -1073     
+ Misses      31350    30688     -662     
+ Partials     5517     5494      -23     
Components Coverage Δ
Client 74.43% <ø> (-0.15%) ⬇️
Core 68.87% <ø> (-0.05%) ⬇️
Go 83.19% <80.64%> (+0.19%) ⬆️
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator.go 87.28% <100.00%> (+1.07%) ⬆️
internal/querynodev2/tasks/query_stream_task.go 78.72% <100.00%> (-0.45%) ⬇️
internal/querynodev2/tasks/query_task.go 90.09% <100.00%> (-0.09%) ⬇️
internal/querynodev2/tasks/search_task.go 84.49% <100.00%> (+0.04%) ⬆️
internal/querynodev2/handlers.go 77.07% <75.00%> (-0.12%) ⬇️
internal/querynodev2/segments/retrieve.go 82.53% <81.81%> (+0.13%) ⬆️
internal/querynodev2/segments/statistics.go 71.79% <45.45%> (-0.43%) ⬇️
internal/querynodev2/segments/search.go 65.95% <75.67%> (+2.48%) ⬆️

... and 204 files with indirect coverage changes