Skip to content

fix grant/revoke v2 meta and unclear error messages

Codecov / codecov/project succeeded Dec 2, 2024 in 1s

81.08% (target 77.00%)

View this Pull Request on Codecov

81.08% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (bec5499) to head (2fac18c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 92.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38110       +/-   ##
===========================================
+ Coverage   68.87%   81.08%   +12.21%     
===========================================
  Files         289     1369     +1080     
  Lines       25484   190978   +165494     
===========================================
+ Hits        17551   154863   +137312     
- Misses       7933    30634    +22701     
- Partials        0     5481     +5481     
Components Coverage Δ
Client 73.67% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.22% <95.91%> (∅)
Files with missing lines Coverage Δ
internal/proxy/impl.go 84.84% <100.00%> (ø)
internal/proxy/util.go 89.93% <100.00%> (ø)
internal/rootcoord/meta_table.go 82.75% <100.00%> (ø)
pkg/util/constant.go 98.36% <100.00%> (ø)
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/merr/utils.go 84.11% <100.00%> (ø)
internal/rootcoord/root_coord.go 89.53% <92.00%> (ø)

... and 1073 files with indirect coverage changes