Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the retrieve plan on heap is used after free when reduce #38842

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 30, 2024

issue: #38731
pr: #38840

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 30, 2024
@chyezh chyezh changed the title fix: the on heap is used after free when reduce fix: the retrieve plan on heap is used after free when reduce Dec 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 30, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 30, 2024
@sre-ci-robot sre-ci-robot merged commit 253860b into milvus-io:2.4 Dec 30, 2024
13 checks passed
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.37%. Comparing base (fec92e9) to head (49b2cec).
Report is 3 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querynodev2/segments/result.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38842      +/-   ##
==========================================
- Coverage   83.37%   80.37%   -3.01%     
==========================================
  Files         809     1077     +268     
  Lines      143064   169559   +26495     
==========================================
+ Hits       119281   136276   +16995     
- Misses      19299    28797    +9498     
- Partials     4484     4486       +2     
Files with missing lines Coverage Δ
internal/querynodev2/segments/result.go 69.68% <0.00%> (ø)

... and 297 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants