Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refine array view to optimize memory usage(#38736) #38808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrPresent-Han
Copy link
Contributor

related: #38736

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 27, 2024
Copy link
Contributor

mergify bot commented Dec 27, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 48a53db to 22404ce Compare December 27, 2024 12:28
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (18a3bc7) to head (22404ce).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38808      +/-   ##
==========================================
+ Coverage   69.45%   69.47%   +0.01%     
==========================================
  Files         294      294              
  Lines       26429    26443      +14     
==========================================
+ Hits        18357    18371      +14     
  Misses       8072     8072              
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.47% <100.00%> (+0.01%) ⬆️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/Array.h 93.40% <100.00%> (+0.41%) ⬆️
internal/core/src/common/Chunk.cpp 70.27% <100.00%> (-1.53%) ⬇️
internal/core/src/storage/MmapChunkManager.cpp 84.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants