Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build break under debug mode #38790

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Dec 26, 2024

See #38435

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@tedxu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Dec 27, 2024

rerun go-sdk

@tedxu
Copy link
Contributor Author

tedxu commented Dec 27, 2024

rerun cpp-unit-test

@tedxu
Copy link
Contributor Author

tedxu commented Dec 27, 2024

/run-cpu-e2e

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (3739446) to head (f6cfd92).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38790      +/-   ##
==========================================
- Coverage   81.14%   81.12%   -0.03%     
==========================================
  Files        1388     1388              
  Lines      196536   196536              
==========================================
- Hits       159486   159446      -40     
- Misses      31462    31497      +35     
- Partials     5588     5593       +5     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.53% <ø> (ø)
Go 83.08% <ø> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 84.15% <ø> (ø)

... and 28 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 27, 2024

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Jan 7, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 7, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 7, 2025
@sunby
Copy link
Contributor

sunby commented Jan 7, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 3dc9515 into milvus-io:master Jan 7, 2025
19 of 20 checks passed
@tedxu tedxu deleted the fix/debug_break branch January 8, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants