Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] update expr version to support method parameter type conversion #38781

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Dec 26, 2024

/kind improvement
issue: #38780

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Dec 26, 2024
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/dependency Pull requests that update a dependency file labels Dec 26, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@SimFG Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.39%. Comparing base (fec92e9) to head (c783694).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38781      +/-   ##
==========================================
- Coverage   83.37%   80.39%   -2.99%     
==========================================
  Files         809     1077     +268     
  Lines      143064   169559   +26495     
==========================================
+ Hits       119281   136317   +17036     
- Misses      19299    28759    +9460     
+ Partials     4484     4483       -1     

see 295 files with indirect coverage changes

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants