Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[Cherr-pick] sealed segment get empty index params when brute force search for bm25 #38752

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 25, 2024

relate: #38236
pr: #38707

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 25, 2024
@aoiasd aoiasd changed the title Fix sealed segment get empty index params when brute force search for bm25 fix:[Cherr-pick] sealed segment get empty index params when brute force search for bm25 Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (d47372e) to head (356bf19).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 1 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38752      +/-   ##
==========================================
- Coverage   81.05%   81.02%   -0.03%     
==========================================
  Files        1381     1381              
  Lines      195158   195158              
==========================================
- Hits       158186   158128      -58     
- Misses      31391    31452      +61     
+ Partials     5581     5578       -3     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.35% <0.00%> (+0.01%) ⬆️
Go 83.00% <ø> (-0.04%) ⬇️
Files with missing lines Coverage Δ
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.92% <0.00%> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 84.42% <0.00%> (ø)

... and 38 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 25, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 930f9e9 into milvus-io:2.5 Dec 26, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants