Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5]Add missing delete metrics (#38634) #38747

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

XuanYang-cn
Copy link
Contributor

Add 2 counter metrics:

  • Total delete entries from deltalog: milvus_datanode_compaction_delete_count
  • Total missing deletes: milvus_datanode_compaction_missing_delete_count

See also: #34665
pr: #38634

Add 2 counter metrics:
- Total delete entries from deltalog:
milvus_datanode_compaction_delete_count
- Total missing deletes: milvus_datanode_compaction_missing_delete_count

See also: milvus-io#34665
pr: milvus-io#38634

Signed-off-by: yangxuan <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 25, 2024
@sre-ci-robot sre-ci-robot requested review from czs007 and sunby December 25, 2024 10:21
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 96.09375% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (a4901ef) to head (2227af7).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/datanode/compaction/merge_sort.go 90.32% 2 Missing and 1 partial ⚠️
...ternal/datanode/compaction/clustering_compactor.go 86.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38747      +/-   ##
==========================================
+ Coverage   81.04%   81.06%   +0.02%     
==========================================
  Files        1381     1381              
  Lines      195154   195195      +41     
==========================================
+ Hits       158164   158244      +80     
+ Misses      31422    31393      -29     
+ Partials     5568     5558      -10     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.05% <96.09%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/datanode/compaction/compactor_common.go 87.33% <100.00%> (+2.84%) ⬆️
internal/datanode/compaction/mix_compactor.go 73.76% <100.00%> (-0.49%) ⬇️
pkg/metrics/datanode_metrics.go 100.00% <100.00%> (ø)
...ternal/datanode/compaction/clustering_compactor.go 65.87% <86.66%> (+0.29%) ⬆️
internal/datanode/compaction/merge_sort.go 79.50% <90.32%> (+0.56%) ⬆️

... and 36 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants