Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert Expose metrics of stanby coordinators (#27698) #38742

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from
Open

fix: Revert Expose metrics of stanby coordinators (#27698) #38742

wants to merge 1 commit into from
+3 −15

Conversation

jaime0815
Copy link
Contributor

issue: #38608
pr: #38620

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@jaime0815 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug labels Dec 25, 2024
@jaime0815 jaime0815 force-pushed the fix-get-metrics-panic-24 branch from 759f846 to 4480d5d Compare December 25, 2024 08:40
@jaime0815 jaime0815 added this to the 2.4.19 milestone Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. labels Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@cydrain cydrain Awaiting requested review from cydrain

Assignees
No one assigned
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
2.4.19
Development

Successfully merging this pull request may close these issues.
2 participants
@jaime0815 @sre-ci-robot