Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add some apis in Restful #38733

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Dec 25, 2024

add some apis in Restful #38709

  • alter/drop collection properties
  • alter/drop index properties
  • alter collection field properties
  • refresh load

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@smellthemoon Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Dec 25, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (c731357) to head (c50caa1).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/request_v2.go 23.80% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38733      +/-   ##
==========================================
+ Coverage   81.06%   81.08%   +0.01%     
==========================================
  Files        1381     1381              
  Lines      195246   195374     +128     
==========================================
+ Hits       158274   158410     +136     
- Misses      31368    31369       +1     
+ Partials     5604     5595       -9     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.07% <87.50%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 92.94% <100.00%> (+0.36%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 81.81% <23.80%> (-15.62%) ⬇️

... and 23 files with indirect coverage changes

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 25, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 31, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Dec 31, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 6b10583 into milvus-io:master Dec 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants