Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Querycoord will trigger unexpected balance task after restart #38725

Merged

Conversation

weiliu1031
Copy link
Contributor

issue: #38606
pr: #38630

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/internal-api labels Dec 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 24, 2024
Copy link
Contributor

mergify bot commented Dec 24, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (9113090) to head (0b1e1d7).
Report is 4 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/querycoordv2/meta/target.go 66.66% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38725      +/-   ##
==========================================
- Coverage   81.06%   81.06%   -0.01%     
==========================================
  Files        1381     1381              
  Lines      195103   195137      +34     
==========================================
+ Hits       158156   158180      +24     
- Misses      31390    31397       +7     
- Partials     5557     5560       +3     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (-0.02%) ⬇️
Go 83.04% <82.35%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/querycoordv2/checkers/balance_checker.go 96.26% <100.00%> (+0.30%) ⬆️
internal/querycoordv2/meta/target_manager.go 89.45% <100.00%> (+0.18%) ⬆️
internal/querycoordv2/meta/target.go 90.76% <66.66%> (-4.19%) ⬇️

... and 24 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 24, 2024
@tedxu
Copy link
Contributor

tedxu commented Dec 25, 2024

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit cb0618b into milvus-io:2.5 Dec 25, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants