Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Querycoord will trigger unexpected balance task after restart #38723

Closed

Conversation

weiliu1031
Copy link
Contributor

issue: #38606
pr: #38630

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/internal-api labels Dec 24, 2024
@sre-ci-robot sre-ci-robot requested review from czs007 and sunby December 24, 2024 13:58
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 24, 2024
@weiliu1031
Copy link
Contributor Author

duplicate pr by mistake

@weiliu1031 weiliu1031 closed this Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (9113090) to head (c023971).
Report is 1 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38723      +/-   ##
==========================================
- Coverage   81.06%   81.05%   -0.01%     
==========================================
  Files        1381     1381              
  Lines      195103   195105       +2     
==========================================
- Hits       158156   158141      -15     
- Misses      31390    31402      +12     
- Partials     5557     5562       +5     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (-0.02%) ⬇️
Go 83.03% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/querycoordv2/meta/target.go 95.04% <100.00%> (+0.08%) ⬆️

... and 22 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants