Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add multiply factor when loading index #38722

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 24, 2024

issue: #38715
pr: #38716

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 24, 2024
Copy link
Contributor

mergify bot commented Dec 24, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (9113090) to head (5751a6e).
Report is 2 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38722      +/-   ##
==========================================
- Coverage   81.06%   81.06%   -0.01%     
==========================================
  Files        1381     1381              
  Lines      195103   195113      +10     
==========================================
+ Hits       158156   158164       +8     
- Misses      31390    31394       +4     
+ Partials     5557     5555       -2     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (-0.02%) ⬇️
Go 83.05% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment.go 64.30% <100.00%> (+0.03%) ⬆️
pkg/util/paramtable/component_param.go 98.38% <100.00%> (+<0.01%) ⬆️

... and 34 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Dec 24, 2024

rerun go-sdk

@chyezh
Copy link
Contributor Author

chyezh commented Dec 24, 2024

rerun ut

@mergify mergify bot added the ci-passed label Dec 24, 2024
@tedxu
Copy link
Contributor

tedxu commented Dec 25, 2024

/lgtm

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 52de43d into milvus-io:2.5 Dec 25, 2024
19 of 20 checks passed
@chyezh chyezh deleted the enhance_mem_index_file_multiply_factor_2_5 branch December 25, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants