Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report error when hints not supported #38717

Merged
merged 2 commits into from
Dec 25, 2024

update

1342f38
Select commit
Loading
Failed to load commit list.
Merged

fix: report error when hints not supported #38717

update
1342f38
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 25, 2024 in 0s

81.10% (target 77.00%)

View this Pull Request on Codecov

81.10% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (636e107) to head (1342f38).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/query/PlanProto.cpp 57.14% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38717      +/-   ##
==========================================
+ Coverage   81.03%   81.10%   +0.06%     
==========================================
  Files        1380     1381       +1     
  Lines      195154   195250      +96     
==========================================
+ Hits       158145   158357     +212     
+ Misses      31438    31322     -116     
  Partials     5571     5571              
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.34% <57.14%> (+<0.01%) ⬆️
Go 83.09% <ø> (+0.08%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/query/PlanProto.cpp 90.09% <57.14%> (-0.19%) ⬇️

... and 38 files with indirect coverage changes