Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix 0 read count during import #38696

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Dec 24, 2024

issue: #38693

pr: #38694

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 24, 2024
Copy link
Contributor

mergify bot commented Dec 24, 2024

@bigsheeper Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Dec 24, 2024
Copy link
Contributor

mergify bot commented Dec 24, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (7363a1c) to head (7dd9048).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38696      +/-   ##
==========================================
+ Coverage   80.38%   83.36%   +2.97%     
==========================================
  Files        1077      809     -268     
  Lines      169449   142961   -26488     
==========================================
- Hits       136219   119173   -17046     
+ Misses      28748    19303    -9445     
- Partials     4482     4485       +3     
Files with missing lines Coverage Δ
internal/util/importutilv2/common/util.go 88.13% <100.00%> (+1.59%) ⬆️

... and 288 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Dec 24, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 24, 2024
@sre-ci-robot sre-ci-robot merged commit 648078e into milvus-io:2.4 Dec 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants