Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add cases for async milvus client #38691

Merged
merged 1 commit into from
Dec 25, 2024
Merged

test: add cases for async milvus client #38691

merged 1 commit into from
Dec 25, 2024

Conversation

ThreadDao
Copy link
Contributor

@ThreadDao ThreadDao commented Dec 24, 2024 •
edited by yanliang567
Loading

issue: #38697
pr: #38699

@ThreadDao ThreadDao added the kind/improvement Changes related to something improve, likes ut and code refactor label Dec 24, 2024
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/test sig/testing labels Dec 24, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 24, 2024

@ThreadDao Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@ThreadDao ThreadDao force-pushed the 2.4-async-client-test branch from 9f440a9 to 51c2738 Compare December 24, 2024 08:22
@mergify mergify bot added ci-passed and removed ci-passed labels Dec 24, 2024
wangting0128
wangting0128 approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@wangting0128 wangting0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThreadDao, wangting0128, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Dec 25, 2024
@sre-ci-robot sre-ci-robot merged commit 604fb75 into milvus-io:2.4 Dec 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangting0128 wangting0128 wangting0128 approved these changes

@binbinlv binbinlv Awaiting requested review from binbinlv

Assignees

@wangting0128 wangting0128

@yanliang567 yanliang567

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor kind/test lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThreadDao @yanliang567 @sre-ci-robot @wangting0128