Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add db name in replica description #38673

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

jaime0815
Copy link
Contributor

issue: #36621
pr: #38672

@sre-ci-robot sre-ci-robot added area/internal-api size/M Denotes a PR that changes 30-99 lines. labels Dec 23, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 23, 2024
@jaime0815 jaime0815 force-pushed the add-db-id-in-replica-25 branch from 4d84de3 to ed2a868 Compare December 23, 2024 13:08
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (f441ccd) to head (cfacbc4).
Report is 2 commits behind head on 2.5.

❗ There is a different number of reports uploaded between BASE (f441ccd) and HEAD (cfacbc4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f441ccd) HEAD (cfacbc4)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38673       +/-   ##
===========================================
- Coverage   81.06%   69.33%   -11.73%     
===========================================
  Files        1381      292     -1089     
  Lines      195157    26187   -168970     
===========================================
- Hits       158206    18158   -140048     
+ Misses      31392     8029    -23363     
+ Partials     5559        0     -5559     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.33% <ø> (ø)
Go ∅ <ø> (∅)

see 1089 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 23, 2024
@jaime0815 jaime0815 force-pushed the add-db-id-in-replica-25 branch from ed2a868 to 92c9fe4 Compare December 25, 2024 06:25
@mergify mergify bot removed the ci-passed label Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the add-db-id-in-replica-25 branch from 92c9fe4 to cfacbc4 Compare December 25, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants