Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip balance on collection with zero row count segment #38665

Closed
wants to merge 1 commit into from

Conversation

weiliu1031
Copy link
Contributor

issue: #38606

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.35%. Comparing base (90de37e) to head (a09c85e).
Report is 13 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (90de37e) and HEAD (a09c85e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (90de37e) HEAD (a09c85e)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38665       +/-   ##
===========================================
- Coverage   81.05%   69.35%   -11.71%     
===========================================
  Files        1381      292     -1089     
  Lines      195090    26187   -168903     
===========================================
- Hits       158131    18162   -139969     
+ Misses      31398     8025    -23373     
+ Partials     5561        0     -5561     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.35% <ø> (+0.01%) ⬆️
Go ∅ <ø> (∅)

see 1090 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 23, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tedxu
Copy link
Contributor

tedxu commented Dec 23, 2024

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants