-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Use Arrow cdata to avoid proto serde for delete #38658
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38658 +/- ##
===========================================
- Coverage 81.13% 69.18% -11.95%
===========================================
Files 1385 294 -1091
Lines 195931 26534 -169397
===========================================
- Hits 158960 18357 -140603
+ Misses 31381 8177 -23204
+ Partials 5590 0 -5590
|
Related to milvus-io#35303 Reference https://arrow.apache.org/docs/format/CDataInterface.html Signed-off-by: Congqi Xia <[email protected]>
9a549d5
to
a59828d
Compare
@congqixia go-sdk check failed, comment |
Related to #35303
Previous PR: #37018
this PR fix misuse of smart ptr and update code due to base branching
Reference https://arrow.apache.org/docs/format/CDataInterface.html