Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use Arrow cdata to avoid proto serde for delete #38658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

Related to #35303
Previous PR: #37018
this PR fix misuse of smart ptr and update code due to base branching

Reference https://arrow.apache.org/docs/format/CDataInterface.html

@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Dec 23, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 104 lines in your changes missing coverage. Please review.

Project coverage is 69.18%. Comparing base (56c5b66) to head (a59828d).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 27 Missing ⚠️
internal/core/src/segcore/SegmentGrowingImpl.cpp 0.00% 27 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 27 Missing ⚠️
internal/core/src/segcore/segment_c.cpp 0.00% 14 Missing ⚠️
internal/core/src/segcore/Utils.cpp 0.00% 9 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (56c5b66) and HEAD (a59828d). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (56c5b66) HEAD (a59828d)
4 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38658       +/-   ##
===========================================
- Coverage   81.13%   69.18%   -11.95%     
===========================================
  Files        1385      294     -1091     
  Lines      195931    26534   -169397     
===========================================
- Hits       158960    18357   -140603     
+ Misses      31381     8177    -23204     
+ Partials     5590        0     -5590     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.18% <0.00%> (-0.28%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 28.57% <ø> (ø)
internal/core/src/segcore/SegmentGrowingImpl.h 69.04% <ø> (ø)
internal/core/src/segcore/SegmentInterface.h 71.15% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 57.14% <ø> (ø)
internal/core/src/segcore/Utils.h 100.00% <ø> (ø)
internal/core/src/segcore/Utils.cpp 68.67% <0.00%> (-1.06%) ⬇️
internal/core/src/segcore/segment_c.cpp 56.01% <0.00%> (-2.40%) ⬇️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.34% <0.00%> (-0.59%) ⬇️
internal/core/src/segcore/SegmentGrowingImpl.cpp 75.25% <0.00%> (-5.45%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.cpp 82.32% <0.00%> (-2.16%) ⬇️

... and 1093 files with indirect coverage changes

@congqixia congqixia force-pushed the enhance/arrow_cdata_delete_2 branch from 9a549d5 to a59828d Compare December 30, 2024 11:20
Copy link
Contributor

mergify bot commented Dec 30, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants