Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove an undefined behavior in index writer #38657

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Dec 23, 2024

No description provided.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 23, 2024
@sunby sunby changed the title enhance: Remove a undefined behavior in index writer enhance: Remove an undefined behavior in index writer Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Dec 23, 2024

/run-cpu-e2e

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (90de37e) to head (1b40e0e).
Report is 55 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38657      +/-   ##
==========================================
- Coverage   81.05%   81.02%   -0.03%     
==========================================
  Files        1381     1380       -1     
  Lines      195090   195145      +55     
==========================================
- Hits       158131   158124       -7     
- Misses      31398    31441      +43     
- Partials     5561     5580      +19     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.01% <ø> (-0.04%) ⬇️

see 45 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 23, 2024
@aoiasd
Copy link
Contributor

aoiasd commented Dec 26, 2024

/lgtm

@tedxu
Copy link
Contributor

tedxu commented Dec 31, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3822819 into milvus-io:master Dec 31, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants