Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Support hybrid search with expression template #38625

Merged

Conversation

xiaocai2333
Copy link
Contributor

issue: #38616

master pr: #38623

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (b132438) to head (abe2c61).
Report is 4 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38625      +/-   ##
==========================================
- Coverage   81.05%   81.03%   -0.02%     
==========================================
  Files        1381     1381              
  Lines      195090   195091       +1     
==========================================
- Hits       158137   158101      -36     
- Misses      31386    31418      +32     
- Partials     5567     5572       +5     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.02% <100.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/search_util.go 81.57% <100.00%> (+0.05%) ⬆️

... and 33 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Dec 20, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 merged commit 7fe2cd0 into milvus-io:2.5 Dec 20, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants