Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix panic caused by removing directory #38622

Merged
merged 3 commits into from
Jan 6, 2025

add debug info

46f238c
Select commit
Loading
Failed to load commit list.
Merged

fix: Fix panic caused by removing directory #38622

add debug info
46f238c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2025 in 0s

81.11% (target 77.00%)

View this Pull Request on Codecov

81.11% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.11%. Comparing base (907fc24) to head (46f238c).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/storage/LocalChunkManager.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38622       +/-   ##
===========================================
+ Coverage   69.54%   81.11%   +11.57%     
===========================================
  Files         296     1387     +1091     
  Lines       26535   196227   +169692     
===========================================
+ Hits        18454   159178   +140724     
- Misses       8081    31455    +23374     
- Partials        0     5594     +5594     
Components Coverage Δ
Client 79.12% <ø> (∅)
Core 69.53% <28.57%> (-0.02%) ⬇️
Go 83.08% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/InvertedIndexTantivy.cpp 92.72% <100.00%> (+0.05%) ⬆️
internal/core/src/storage/LocalChunkManager.cpp 66.00% <0.00%> (-2.75%) ⬇️

... and 1091 files with indirect coverage changes