Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix update loading collection's load config doesn't work #38595

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #38594

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels Dec 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 19, 2024
@chyezh
Copy link
Contributor

chyezh commented Dec 19, 2024

/lgtm

Signed-off-by: Wei Liu <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (8fcb33c) to head (1acd8a8).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/services.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38595   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files        1379     1379           
  Lines      194495   194495           
=======================================
+ Hits       157546   157548    +2     
+ Misses      31393    31384    -9     
- Partials     5556     5563    +7     
Components Coverage Δ
Client 75.88% <ø> (ø)
Core 69.35% <ø> (+0.01%) ⬆️
Go 83.03% <50.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/querycoordv2/services.go 85.94% <50.00%> (-0.64%) ⬇️

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 19, 2024
@chyezh
Copy link
Contributor

chyezh commented Dec 20, 2024

/lgtm

@tedxu
Copy link
Contributor

tedxu commented Dec 25, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 25f0c82 into milvus-io:master Dec 25, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants