Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Return collection not loaded rather than not found on querynode #38593

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #38586

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 19, 2024
Copy link
Contributor

mergify bot commented Dec 19, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Dec 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (90de37e) to head (856c207).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38593      +/-   ##
==========================================
- Coverage   81.05%   81.02%   -0.04%     
==========================================
  Files        1381     1381              
  Lines      195090   195090              
==========================================
- Hits       158131   158068      -63     
- Misses      31398    31449      +51     
- Partials     5561     5573      +12     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.00% <100.00%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/querynodev2/services.go 86.77% <100.00%> (-0.66%) ⬇️

... and 32 files with indirect coverage changes

@xiaocai2333 xiaocai2333 force-pushed the refine_querynode_coll_log branch from 8efae8c to 856c207 Compare December 20, 2024 10:44
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 20, 2024
@mergify mergify bot added the ci-passed label Dec 20, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 23, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit bb5f38e into milvus-io:master Dec 23, 2024
19 of 20 checks passed
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants