Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] clean compaction task in compactionHandler (#38170) #38584

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #35711

master pr: #38170

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 19, 2024
@xiaocai2333
Copy link
Contributor Author

/hold
wait 2.4.18 released

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 19, 2024
issue: milvus-io#35711

---------

Signed-off-by: wayblink <[email protected]>
Signed-off-by: Cai Zhang <[email protected]>
Co-authored-by: wayblink <[email protected]>
@xiaocai2333 xiaocai2333 force-pushed the clean_compaction_task_pick branch from 62b22e1 to 76c0d41 Compare December 19, 2024 08:26
@mergify mergify bot added the ci-passed label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 82.08955% with 36 lines in your changes missing coverage. Please review.

Project coverage is 80.43%. Comparing base (451deb3) to head (76c0d41).
Report is 6 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/compaction_task_clustering.go 83.49% 13 Missing and 4 partials ⚠️
internal/datacoord/compaction_task_mix.go 50.00% 10 Missing and 1 partial ⚠️
internal/datacoord/partition_stats_meta.go 76.19% 3 Missing and 2 partials ⚠️
internal/datacoord/compaction_task_l0.go 75.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38584      +/-   ##
==========================================
+ Coverage   72.14%   80.43%   +8.29%     
==========================================
  Files        1077     1077              
  Lines      169415   169518     +103     
==========================================
+ Hits       122217   136347   +14130     
+ Misses      42719    28685   -14034     
- Partials     4479     4486       +7     
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 78.57% <100.00%> (+1.55%) ⬆️
internal/datacoord/compaction_task.go 88.88% <ø> (ø)
internal/datacoord/meta.go 89.85% <100.00%> (+1.61%) ⬆️
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/merr/utils.go 83.27% <100.00%> (+0.12%) ⬆️
internal/datacoord/compaction_task_l0.go 94.09% <75.00%> (-1.15%) ⬇️
internal/datacoord/partition_stats_meta.go 52.12% <76.19%> (+8.49%) ⬆️
internal/datacoord/compaction_task_mix.go 65.15% <50.00%> (+8.12%) ⬆️
internal/datacoord/compaction_task_clustering.go 79.00% <83.49%> (+6.45%) ⬆️

... and 223 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

/unhold

@czs007
Copy link
Collaborator

czs007 commented Dec 24, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit afaabc2 into milvus-io:2.4 Dec 24, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants