Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: field stringtype maxlength raise to 1M #38582

Closed
wants to merge 3 commits into from

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 19, 2024

enhance: field stringtype maxlength raise to 1M
issue: #37436

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JsDove
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 19, 2024
Signed-off-by: Xianhui.Lin <[email protected]>

modify the message hint

Signed-off-by: Xianhui.Lin <[email protected]>
Copy link
Contributor

mergify bot commented Dec 19, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 19, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (306e5e6) to head (bd91bf1).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task.go 0.00% 1 Missing ⚠️
internal/proxy/util.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38582      +/-   ##
==========================================
+ Coverage   80.99%   81.01%   +0.02%     
==========================================
  Files        1379     1379              
  Lines      194492   194495       +3     
==========================================
+ Hits       157523   157570      +47     
+ Misses      31403    31370      -33     
+ Partials     5566     5555      -11     
Components Coverage Δ
Client 75.88% <ø> (ø)
Core 69.33% <ø> (+0.01%) ⬆️
Go 83.05% <0.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/task.go 80.69% <0.00%> (ø)
internal/proxy/util.go 89.63% <0.00%> (ø)

... and 32 files with indirect coverage changes

@JsDove JsDove changed the title enhance: remove field stringtype length limit enhance: field stringtype maxlength raise to 1M Dec 19, 2024
Copy link
Contributor

mergify bot commented Dec 19, 2024

@JsDove Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Dec 19, 2024
@JsDove JsDove closed this Dec 19, 2024
Copy link
Contributor

mergify bot commented Dec 19, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement needs-dco DCO is missing in this pull request. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants