Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix delete record assert failed #38580

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Dec 19, 2024

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 19, 2024
@zhagnlu zhagnlu force-pushed the fix_delete_assert_failed branch 3 times, most recently from ca6729c to d120cf4 Compare December 19, 2024 07:40
@zhagnlu zhagnlu force-pushed the fix_delete_assert_failed branch from d120cf4 to 52f1347 Compare December 19, 2024 07:42
Copy link
Contributor

mergify bot commented Dec 19, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Dec 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 19, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 19, 2024

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Dec 19, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 19, 2024

rerun go-sdk

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (b537a72) to head (52f1347).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38580       +/-   ##
===========================================
+ Coverage   69.33%   80.98%   +11.64%     
===========================================
  Files         292     1379     +1087     
  Lines       26189   194495   +168306     
===========================================
+ Hits        18159   157517   +139358     
- Misses       8030    31407    +23377     
- Partials        0     5571     +5571     
Components Coverage Δ
Client 75.88% <ø> (∅)
Core 69.33% <100.00%> (+<0.01%) ⬆️
Go 83.02% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/TextMatchIndex.cpp 40.64% <ø> (ø)
internal/core/src/segcore/DeletedRecord.h 88.80% <100.00%> (+0.61%) ⬆️

... and 1087 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 19, 2024
@sre-ci-robot sre-ci-robot merged commit 8fcb33c into milvus-io:master Dec 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants