Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SyncSegments rpc always failed #38578

Merged

Conversation

congqixia
Copy link
Contributor

miss the patch due to code branching
previous pr: #38032

miss the patch due to code branching
previous pr: milvus-io#38032

Co-authored-by: Wei Liu <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Dec 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 19, 2024
@congqixia congqixia added this to the 2.5.0 milestone Dec 19, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (306e5e6) to head (519800b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/session/datanode_manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38578      +/-   ##
==========================================
+ Coverage   80.99%   81.00%   +0.01%     
==========================================
  Files        1379     1379              
  Lines      194492   194492              
==========================================
+ Hits       157523   157553      +30     
+ Misses      31403    31381      -22     
+ Partials     5566     5558       -8     
Components Coverage Δ
Client 75.88% <ø> (ø)
Core 69.32% <ø> (ø)
Go 83.04% <0.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/session/datanode_manager.go 67.22% <0.00%> (ø)

... and 34 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 19, 2024
@sre-ci-robot sre-ci-robot merged commit 3d360c0 into milvus-io:master Dec 19, 2024
19 of 20 checks passed
@congqixia congqixia deleted the fix/sync_segment_always_fail branch December 20, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants