Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [skip e2e]metrics json tag unmarshall failed #38554

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #38551

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@fb0e689). Learn more about missing BASE report.
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #38554   +/-   ##
=========================================
  Coverage          ?   80.96%           
=========================================
  Files             ?     1379           
  Lines             ?   194360           
  Branches          ?        0           
=========================================
  Hits              ?   157372           
  Misses            ?    31433           
  Partials          ?     5555           
Components Coverage Δ
Client 75.27% <ø> (?)
Core 69.32% <ø> (?)
Go 83.00% <ø> (?)
Files with missing lines Coverage Δ
pkg/util/metricsinfo/metrics_info.go 100.00% <ø> (ø)

@mergify mergify bot added the ci-passed label Dec 18, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1639779 into milvus-io:master Dec 18, 2024
19 checks passed
@jaime0815 jaime0815 changed the title fix: [skip e2e]metrics josn tag unmarshall failed fix: [skip e2e]metrics json tag unmarshall failed Dec 18, 2024
@jaime0815 jaime0815 deleted the fix-metrics-tag branch December 18, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants