Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix snapshot or size when query #38549

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Dec 18, 2024

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 18, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 18, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 18, 2024

rerun go-sdk

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (6ee94d0) to head (e000cbc).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38549      +/-   ##
==========================================
+ Coverage   80.95%   80.97%   +0.02%     
==========================================
  Files        1379     1379              
  Lines      194360   194361       +1     
==========================================
+ Hits       157343   157391      +48     
+ Misses      31450    31412      -38     
+ Partials     5567     5558       -9     
Components Coverage Δ
Client 75.27% <ø> (ø)
Core 69.32% <100.00%> (+<0.01%) ⬆️
Go 83.02% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/segcore/DeletedRecord.h 88.18% <100.00%> (+0.09%) ⬆️

... and 33 files with indirect coverage changes

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 18, 2024

rerun ut

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Dec 18, 2024
@sre-ci-robot sre-ci-robot merged commit 87056be into milvus-io:master Dec 18, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants