Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix stats task wrong RootPath when upload binlog #38539

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #38336

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 17, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 17, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added this to the 2.5.0 milestone Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (b9d8c5c) to head (05fc163).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38539       +/-   ##
===========================================
+ Coverage   69.34%   80.98%   +11.63%     
===========================================
  Files         292     1378     +1086     
  Lines       26168   194187   +168019     
===========================================
+ Hits        18146   157255   +139109     
- Misses       8022    31384    +23362     
- Partials        0     5548     +5548     
Components Coverage Δ
Client 74.52% <ø> (∅)
Core 69.34% <ø> (-0.01%) ⬇️
Go 83.03% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/indexnode/task_stats.go 70.33% <100.00%> (ø)

... and 1091 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Dec 17, 2024
@sre-ci-robot sre-ci-robot merged commit 7a05b5b into milvus-io:master Dec 17, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants