Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [skip e2e] refine display format #38537

Merged

Conversation

jaime0815
Copy link
Contributor

issue: #36621

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 17, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 17, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 17, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@jaime0815
Copy link
Contributor Author

rerun go-sdk

@jaime0815
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Dec 17, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 17, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815
Copy link
Contributor Author

rerun go-sdk

@jaime0815
Copy link
Contributor Author

rerun cpp-unit-test

@jaime0815 jaime0815 force-pushed the webui-refine-display-format branch from a536bd8 to a7c7c8a Compare December 17, 2024 12:50
@SimFG
Copy link
Contributor

SimFG commented Dec 17, 2024

/lgtm

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (9afcc5b) to head (a7c7c8a).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38537   +/-   ##
=======================================
  Coverage   80.97%   80.98%           
=======================================
  Files        1378     1378           
  Lines      194185   194189    +4     
=======================================
+ Hits       157238   157259   +21     
+ Misses      31402    31391   -11     
+ Partials     5545     5539    -6     
Components Coverage Δ
Client 74.52% <ø> (ø)
Core 69.34% <0.00%> (-0.01%) ⬇️
Go 83.03% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/http_req_impl.go 69.49% <100.00%> (ø)
pkg/util/metricsinfo/metrics_info.go 100.00% <ø> (ø)

... and 34 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 17, 2024
@sre-ci-robot sre-ci-robot merged commit 4d5572d into milvus-io:master Dec 17, 2024
19 checks passed
@jaime0815 jaime0815 deleted the webui-refine-display-format branch December 18, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants