Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix inaccurate general count #38525

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

bigsheeper
Copy link
Contributor

Checking general count should only count healthy collections and partitions.

issue: #37630

pr: #38524

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 17, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and yhmo December 17, 2024 08:27
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 17, 2024
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot added the ci-passed label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.38%. Comparing base (6f573f6) to head (0daee25).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38525      +/-   ##
==========================================
+ Coverage   72.15%   80.38%   +8.22%     
==========================================
  Files        1077     1077              
  Lines      169342   169344       +2     
==========================================
+ Hits       122185   136122   +13937     
+ Misses      42685    28750   -13935     
  Partials     4472     4472              
Files with missing lines Coverage Δ
internal/rootcoord/meta_table.go 83.97% <100.00%> (+0.10%) ⬆️

... and 229 files with indirect coverage changes

@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 18, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 70d2b58 into milvus-io:2.4 Dec 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants