Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new path for streamingnode recovery info #38516

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 17, 2024

issue: #38399

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 17, 2024
@chyezh
Copy link
Contributor Author

chyezh commented Dec 17, 2024

We need add more recovery info for a wal, old path is not good enough for extension, so change it with a global directory for every wal.

@chyezh chyezh self-assigned this Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (d3c174b) to head (b6a78d8).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38516       +/-   ##
===========================================
+ Coverage   69.34%   80.96%   +11.62%     
===========================================
  Files         292     1377     +1085     
  Lines       26168   193993   +167825     
===========================================
+ Hits        18146   157066   +138920     
- Misses       8022    31385    +23363     
- Partials        0     5542     +5542     
Components Coverage Δ
Client 74.58% <ø> (∅)
Core 69.34% <ø> (ø)
Go 83.00% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/metastore/kv/streamingnode/kv_catalog.go 75.51% <100.00%> (ø)

... and 1083 files with indirect coverage changes

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 8916fbf into milvus-io:master Dec 17, 2024
20 checks passed
@chyezh chyezh deleted the fix_rename_the_streaming_meta branch December 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants