Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:remove incorrect assert for delete query #38509

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Dec 17, 2024

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 17, 2024
Copy link
Contributor

mergify bot commented Dec 17, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@yanliang567 yanliang567 added this to the 2.5.0 milestone Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (d3c174b) to head (a413448).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38509       +/-   ##
===========================================
+ Coverage   69.34%   80.98%   +11.63%     
===========================================
  Files         292     1377     +1085     
  Lines       26168   193994   +167826     
===========================================
+ Hits        18146   157097   +138951     
- Misses       8022    31347    +23325     
- Partials        0     5550     +5550     
Components Coverage Δ
Client 74.58% <ø> (∅)
Core 69.34% <100.00%> (ø)
Go 83.02% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/DeletedRecord.h 88.09% <100.00%> (ø)

... and 1085 files with indirect coverage changes

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will the barrier be smaller than the delete offset?

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 17, 2024

When will the barrier be smaller than the delete offset?

when query timestap less than lastest insert/delete timestamp because query(read) and insert/delete(write) is async

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@liliu-z
Copy link
Member

liliu-z commented Dec 17, 2024

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Dec 17, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, liliu-z, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d0a7e98 into milvus-io:master Dec 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants