-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:remove incorrect assert for delete query #38509
Conversation
@zhagnlu go-sdk check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38509 +/- ##
===========================================
+ Coverage 69.34% 80.98% +11.63%
===========================================
Files 292 1377 +1085
Lines 26168 193994 +167826
===========================================
+ Hits 18146 157097 +138951
- Misses 8022 31347 +23325
- Partials 0 5550 +5550
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will the barrier be smaller than the delete offset?
when query timestap less than lastest insert/delete timestamp because query(read) and insert/delete(write) is async |
Signed-off-by: luzhang <[email protected]>
6ce237b
to
a413448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, liliu-z, zhagnlu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#38472