-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix chunked segment can not warmup using mmap #38492
Conversation
ChunkedColumn does not use MmapChunkManager now so we use a file to mmap. |
@sunby E2e jenkins job failed, comment |
@sunby go-sdk check failed, comment |
auto dir = path.parent_path(); | ||
std::filesystem::create_directories(dir); | ||
|
||
auto file = File::Open(path.string(), O_CREAT | O_TRUNC | O_RDWR); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use mmap manager?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use mmap manager?
Chunk and ChunkedColumn will be changed a lot if I use mmap here. Will change it to MmapChunkManager later.
/lgtm |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38492 +/- ##
==========================================
+ Coverage 80.91% 80.93% +0.01%
==========================================
Files 1373 1373
Lines 193158 193191 +33
==========================================
+ Hits 156295 156360 +65
+ Misses 31349 31305 -44
- Partials 5514 5526 +12
|
Signed-off-by: sunby <[email protected]>
Signed-off-by: sunby <[email protected]>
Signed-off-by: sunby <[email protected]>
Signed-off-by: sunby <[email protected]>
a440190
to
5b9f6dd
Compare
Signed-off-by: sunby <[email protected]>
@sunby E2e jenkins job failed, comment |
@sunby go-sdk check failed, comment |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, sunby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #38410