-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: ppc64le support with Buildkite CI job #38485
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sumitd2 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sumitd2 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@sumitd2 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
* Add ppc64le workflow * Add ppc64le build scripts for buildkite * Update sonic.go * Create sonic_ppc64le.go * Update 3rdparty_build.sh * Update versions.txt * Update conanfile.py * Update Makefile * Update ppc64le-build-ubi9.3.sh * Update ppc64le.yaml * Update ppc64le-docker-build-test.sh * Update ppc64le.yaml * Update ppc64le-docker-build-test.sh * Update ppc64le.yaml * Update ppc64le.yaml * Update ppc64le.yaml * Update ppc64le.yaml * Update ppc64le.yaml * Update ppc64le.yaml * Update ppc64le.yaml * Update ppc64le.yaml * Update versions.txt * Update ppc64le.yaml * Update sonic.go * Update ppc64le-build-ubi9.3.sh * Update 3rdparty_build.sh Signed-off-by: Sumit Dubey <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38485 +/- ##
==========================================
+ Coverage 80.91% 82.75% +1.83%
==========================================
Files 1373 1081 -292
Lines 193158 167023 -26135
==========================================
- Hits 156295 138218 -18077
+ Misses 31349 23279 -8070
- Partials 5514 5526 +12
|
Signed-off-by: Sumit Dubey <[email protected]>
@xiaofan-luan To get the ppc64le GHA task passing you will have to create a free Buildkite account, and connect this repo to it. Then create a pipeline (without hooks) which will call scripts/ppc64le-docker-build-test.sh. Then you need to provide me with the pipeline name, the api token (with read-builds and write-builds scope), and the agent token to be updated on the OSU server you have been assigned by us. The whole process shouldn't take more than 10 minutes. (Buildkite has been chosen because its agent supports power). |
issue: #29566