Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: ppc64le support with Buildkite CI job #38485

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sumitd2
Copy link

@sumitd2 sumitd2 commented Dec 16, 2024

issue: #29566

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sumitd2
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/compilation labels Dec 16, 2024
Copy link
Contributor

mergify bot commented Dec 16, 2024

@sumitd2 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Dec 16, 2024
Copy link
Contributor

mergify bot commented Dec 16, 2024

@sumitd2

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@sumitd2 sumitd2 changed the title ppc64le support with Buildkite CI job enhance: ppc64le support with Buildkite CI job Dec 16, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Dec 16, 2024
Copy link
Contributor

mergify bot commented Dec 16, 2024

@sumitd2 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

* Add ppc64le workflow

* Add ppc64le build scripts for buildkite

* Update sonic.go

* Create sonic_ppc64le.go

* Update 3rdparty_build.sh

* Update versions.txt

* Update conanfile.py

* Update Makefile

* Update ppc64le-build-ubi9.3.sh

* Update ppc64le.yaml

* Update ppc64le-docker-build-test.sh

* Update ppc64le.yaml

* Update ppc64le-docker-build-test.sh

* Update ppc64le.yaml

* Update ppc64le.yaml

* Update ppc64le.yaml

* Update ppc64le.yaml

* Update ppc64le.yaml

* Update ppc64le.yaml

* Update ppc64le.yaml

* Update ppc64le.yaml

* Update versions.txt

* Update ppc64le.yaml

* Update sonic.go

* Update ppc64le-build-ubi9.3.sh

* Update 3rdparty_build.sh

Signed-off-by: Sumit Dubey <[email protected]>
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. do-not-merge/missing-related-issue labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (3e2a2f2) to head (fdee245).
Report is 61 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38485      +/-   ##
==========================================
+ Coverage   80.91%   82.75%   +1.83%     
==========================================
  Files        1373     1081     -292     
  Lines      193158   167023   -26135     
==========================================
- Hits       156295   138218   -18077     
+ Misses      31349    23279    -8070     
- Partials     5514     5526      +12     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core ∅ <ø> (∅)
Go 82.98% <ø> (-0.04%) ⬇️

see 321 files with indirect coverage changes

@sumitd2
Copy link
Author

sumitd2 commented Dec 17, 2024

@xiaofan-luan To get the ppc64le GHA task passing you will have to create a free Buildkite account, and connect this repo to it. Then create a pipeline (without hooks) which will call scripts/ppc64le-docker-build-test.sh. Then you need to provide me with the pipeline name, the api token (with read-builds and write-builds scope), and the agent token to be updated on the OSU server you have been assigned by us. The whole process shouldn't take more than 10 minutes. (Buildkite has been chosen because its agent supports power).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants