Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: allow hyphen in partition name #38461

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Dec 14, 2024

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (058c2ab) to head (d9a9c6c).
Report is 1 commits behind head on hotfix-2.4.17.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           hotfix-2.4.17   #38461   +/-   ##
==============================================
  Coverage          80.63%   80.63%           
==============================================
  Files               1069     1069           
  Lines             166987   166987           
==============================================
+ Hits              134653   134658    +5     
+ Misses             27931    27929    -2     
+ Partials            4403     4400    -3     
Files with missing lines Coverage Δ
internal/proxy/util.go 90.64% <100.00%> (ø)

... and 38 files with indirect coverage changes

Signed-off-by: sunby <[email protected]>
@sunby
Copy link
Contributor Author

sunby commented Dec 14, 2024

/run-cpu-e2e

Signed-off-by: sunby <[email protected]>
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 15, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan xiaofan-luan merged commit ac3dcb6 into milvus-io:hotfix-2.4.17 Dec 16, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants