Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support tracing for async watch channels #38444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tinswzy
Copy link
Contributor

@tinswzy tinswzy commented Dec 13, 2024

issue: #35917
Support tracing for async watch channels

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 13, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tinswzy
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 13, 2024
@tinswzy tinswzy force-pushed the enhance_async_watch_chan_trace branch 2 times, most recently from 4c2d9be to 2e3850f Compare December 13, 2024 09:10
Copy link
Contributor

mergify bot commented Dec 13, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy tinswzy force-pushed the enhance_async_watch_chan_trace branch from 2e3850f to 01164a2 Compare December 14, 2024 14:14
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 93.17406% with 20 lines in your changes missing coverage. Please review.

Project coverage is 81.13%. Comparing base (4df444e) to head (7066afe).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/channel_manager.go 87.50% 5 Missing and 2 partials ⚠️
internal/datacoord/channel_store.go 83.33% 2 Missing and 1 partial ⚠️
internal/flushcommon/pipeline/data_sync_service.go 76.92% 2 Missing and 1 partial ⚠️
internal/datacoord/channel.go 83.33% 1 Missing ⚠️
internal/datacoord/services.go 91.66% 0 Missing and 1 partial ⚠️
internal/flushcommon/broker/datacoord.go 66.66% 1 Missing ⚠️
internal/flushcommon/syncmgr/meta_writer.go 0.00% 1 Missing ⚠️
internal/querycoordv2/services.go 75.00% 1 Missing ⚠️
pkg/config/etcd_source.go 0.00% 1 Missing ⚠️
pkg/mq/msgstream/mq_msgstream.go 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38444      +/-   ##
==========================================
+ Coverage   81.09%   81.13%   +0.04%     
==========================================
  Files        1383     1385       +2     
  Lines      195636   195959     +323     
==========================================
+ Hits       158642   158996     +354     
+ Misses      31404    31376      -28     
+ Partials     5590     5587       -3     
Components Coverage Δ
Client 78.73% <ø> (+0.47%) ⬆️
Core 69.45% <ø> (+0.01%) ⬆️
Go 83.12% <93.17%> (+0.04%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/cluster.go 97.22% <100.00%> (ø)
internal/datacoord/meta.go 89.68% <100.00%> (+0.01%) ⬆️
internal/datacoord/metrics_info.go 84.93% <100.00%> (ø)
internal/datacoord/policy.go 85.71% <100.00%> (ø)
internal/datacoord/sync_segments_scheduler.go 100.00% <100.00%> (ø)
internal/datacoord/util.go 98.68% <100.00%> (ø)
internal/datanode/channel/channel_manager.go 89.54% <100.00%> (+0.36%) ⬆️
internal/datanode/services.go 85.01% <100.00%> (ø)
...hcommon/pipeline/flow_graph_dmstream_input_node.go 94.11% <100.00%> (+5.88%) ⬆️
internal/kv/etcd/etcd_kv.go 80.68% <100.00%> (+0.38%) ⬆️
... and 36 more

... and 35 files with indirect coverage changes

@tinswzy tinswzy force-pushed the enhance_async_watch_chan_trace branch from 01164a2 to 27a5e99 Compare December 14, 2024 15:32
Copy link
Contributor

mergify bot commented Dec 14, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 14, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy tinswzy force-pushed the enhance_async_watch_chan_trace branch 3 times, most recently from 1c9dfbe to 8ca39c7 Compare December 16, 2024 01:44
Copy link
Contributor

mergify bot commented Dec 16, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy tinswzy force-pushed the enhance_async_watch_chan_trace branch from 8ca39c7 to 131f2ab Compare December 16, 2024 02:25
@mergify mergify bot added the ci-passed label Dec 16, 2024
@czs007 czs007 added this to the 2.5.1 milestone Dec 17, 2024
@tinswzy tinswzy force-pushed the enhance_async_watch_chan_trace branch from 131f2ab to ac50091 Compare December 18, 2024 08:43
@mergify mergify bot added ci-passed and removed ci-passed labels Dec 18, 2024
@czs007 czs007 removed this from the 2.5.1 milestone Dec 26, 2024
@tinswzy tinswzy force-pushed the enhance_async_watch_chan_trace branch from ac50091 to f8aefe8 Compare December 27, 2024 06:02
@mergify mergify bot removed the ci-passed label Dec 27, 2024
Copy link
Contributor

mergify bot commented Dec 27, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented Dec 27, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 27, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy tinswzy force-pushed the enhance_async_watch_chan_trace branch from f8aefe8 to 7066afe Compare December 27, 2024 08:42
Copy link
Contributor

mergify bot commented Dec 27, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented Dec 27, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants