Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync task still running after DataNode has stopped #38441

Merged

Conversation

jaime0815
Copy link
Contributor

issue: #38319
pr: #38377

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 13, 2024
Copy link
Contributor

mergify bot commented Dec 13, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop-24 branch from 927cbb3 to ac4aed0 Compare December 16, 2024 04:01
Copy link
Contributor

mergify bot commented Dec 16, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop-24 branch from ac4aed0 to 4ebd6e4 Compare December 16, 2024 06:29
Copy link
Contributor

mergify bot commented Dec 16, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Dec 16, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.

Project coverage is 83.36%. Comparing base (1da4ac4) to head (5aa663c).
Report is 12 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datanode/writebuffer/write_buffer.go 33.33% 4 Missing and 2 partials ⚠️
internal/datanode/importv2/task_import.go 20.00% 3 Missing and 1 partial ⚠️
internal/datanode/importv2/task_l0_import.go 20.00% 3 Missing and 1 partial ⚠️
internal/datanode/data_node.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38441      +/-   ##
==========================================
+ Coverage   79.50%   83.36%   +3.85%     
==========================================
  Files        1077      809     -268     
  Lines      169330   142904   -26426     
==========================================
- Hits       134633   119127   -15506     
+ Misses      30234    19295   -10939     
- Partials     4463     4482      +19     
Files with missing lines Coverage Δ
internal/datanode/syncmgr/sync_manager.go 79.74% <100.00%> (+1.66%) ⬆️
pkg/util/conc/pool.go 88.57% <100.00%> (+0.69%) ⬆️
pkg/util/paramtable/component_param.go 98.38% <100.00%> (+<0.01%) ⬆️
internal/datanode/data_node.go 81.27% <40.00%> (-0.71%) ⬇️
internal/datanode/importv2/task_import.go 80.89% <20.00%> (-2.12%) ⬇️
internal/datanode/importv2/task_l0_import.go 68.75% <20.00%> (-1.97%) ⬇️
internal/datanode/writebuffer/write_buffer.go 75.66% <33.33%> (-0.98%) ⬇️

... and 309 files with indirect coverage changes

@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop-24 branch from 49ba8ff to 6acf9a6 Compare December 16, 2024 09:40
@mergify mergify bot added the ci-passed label Dec 16, 2024
@jaime0815 jaime0815 added this to the 2.4.18 milestone Dec 18, 2024
@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop-24 branch from 6acf9a6 to 5aa663c Compare December 18, 2024 02:32
@mergify mergify bot removed the ci-passed label Dec 18, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor Author

/hold

@mergify mergify bot added the ci-passed label Dec 18, 2024
@sre-ci-robot sre-ci-robot merged commit ee7dffc into milvus-io:2.4 Dec 18, 2024
14 of 15 checks passed
@jaime0815 jaime0815 deleted the fix-sync-task-run-after-dn-stop-24 branch December 18, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants