Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add file info log when mmap failed. #38386

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Dec 11, 2024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 11, 2024
Copy link
Contributor

mergify bot commented Dec 11, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (dc85d8e) to head (0bc5ee5).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/storage/MmapChunkManager.cpp 12.50% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38386      +/-   ##
==========================================
+ Coverage   78.82%   80.91%   +2.08%     
==========================================
  Files        1368     1376       +8     
  Lines      191711   193041    +1330     
==========================================
+ Hits       151114   156195    +5081     
+ Misses      35116    31327    -3789     
- Partials     5481     5519      +38     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.92% <12.50%> (ø)
Go 83.02% <72.64%> (+2.48%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/storage/MmapChunkManager.cpp 84.00% <12.50%> (ø)

... and 250 files with indirect coverage changes

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 12, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 12, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6ea1526 into milvus-io:master Dec 15, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants